Add optional force_fetch field for all dependency types
#1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/dependency-models
branch
from
f0b716e
to
1ecf7e6
Compare
simu
changed the title
force_fetch fields for Git and HTTP(S) dependenciesforce_fetch fields for all dependency types
simu
changed the title
force_fetch fields for all dependency typesforce_fetch field for all dependency types
ademariag
approved these changes
Sep 25, 2024
In `kapitan/targets.py` we access the `force_fetch` field regardless of dependency type if force fetching wasn't requested globally.
auto-merge was automatically disabled
September 25, 2024 11:43
Head branch was pushed to by a user without write access
simu
force-pushed
the
fix/dependency-models
branch
from
8575058
to
3e4d677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Move the optional
force_fetchfield to theKapitanDependencyBaseConfigtype.We access the
force_fetchfield without regard to the dependency type inkapitan/kapitan/targets.py
Line 118 in 593e5f9
Docs and Tests